Re: Review Request 35347: Patch for KAFKA-2249

> On June 11, 2015, 11:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 964-965 > > > > > > Is this castable since props is a map? Also, toProps is really just > > used by LogConfi

Re: Review Request 35347: Patch for KAFKA-2249

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/ --- (Updated June 18, 2015, 12:35 a.m.) Review request for kafka. Bugs: KAFKA-224

Re: Review Request 35347: Patch for KAFKA-2249

> On June 11, 2015, 11:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 964-965 > > > > > > Is this castable since props is a map? Also, toProps is really just > > used by LogConfi

Re: Review Request 35347: Patch for KAFKA-2249

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/#review87981 --- Also, could you add a main() method in KafkaConfig like that in Prod

Re: Review Request 35347: Patch for KAFKA-2249

> On June 11, 2015, 11:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 485 > > > > > > Is there a particular reason to change this to a long? It is used as LONG everywhere in the c

Re: Review Request 35347: Patch for KAFKA-2249

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/#review87643 --- Thanks a lot for cleaning this up! A few comments below. core/src/

Review Request 35347: Patch for KAFKA-2249

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/ --- Review request for kafka. Bugs: KAFKA-2249 https://issues.apache.org/jira/b