Re: Review Request 34965: Patch for KAFKA-2241

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965/ --- (Updated July 13, 2015, 9:52 p.m.) Review request for kafka. Bugs: KAFKA-2241

Re: Review Request 34965: Patch for KAFKA-2241

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965/ --- (Updated July 13, 2015, 8:30 p.m.) Review request for kafka. Bugs: KAFKA-2241

Re: Review Request 34965: Patch for KAFKA-2241

> On July 9, 2015, 7:19 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 76 > > > > > > You could get around the above by retaining this call to > > simpleConsumer.close (a

Re: Review Request 34965: Patch for KAFKA-2241

> On July 9, 2015, 7:19 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 76 > > > > > > You could get around the above by retaining this call to > > simpleConsumer.close (a

Re: Review Request 34965: Patch for KAFKA-2241

> On July 9, 2015, 7:19 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 76 > > > > > > You could get around the above by retaining this call to > > simpleConsumer.close (a

Re: Review Request 34965: Patch for KAFKA-2241

> On July 9, 2015, 7:19 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 71 > > > > > > As you probably noticed synchronization in the > > AbstractFetcherManager/Thread cla

Re: Review Request 34965: Patch for KAFKA-2241

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965/ --- (Updated July 9, 2015, 10:35 p.m.) Review request for kafka. Bugs: KAFKA-2241

Re: Review Request 34965: Patch for KAFKA-2241

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965/#review91159 --- core/src/main/scala/kafka/server/AbstractFetcherThread.scala (line

Re: Review Request 34965: Patch for KAFKA-2241

> On June 3, 2015, 6:53 p.m., Aditya Auradkar wrote: > > core/src/main/scala/kafka/consumer/SimpleConsumer.scala, line 61 > > > > > > Why not simply modify the close method to disconnect outside the > > synchronized bl

Re: Review Request 34965: Patch for KAFKA-2241

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965/ --- (Updated June 3, 2015, 10:30 p.m.) Review request for kafka. Bugs: KAFKA-2241

Re: Review Request 34965: Patch for KAFKA-2241

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965/#review86460 --- This may be hard to do in a unit test, but can you check if it's fea

Review Request 34965: Patch for KAFKA-2241

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965/ --- Review request for kafka. Bugs: KAFKA-2241 https://issues.apache.org/jira/b