Re: Review Request 34805: Patch for KAFKA-2213

2015-08-20 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- (Updated Aug. 20, 2015, 11:37 a.m.) Review request for kafka. Bugs: KAFKA-221

Re: Review Request 34805: Patch for KAFKA-2213

2015-07-10 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/#review91298 --- Joel, need your inputs for proceeding further on this. - Manikumar

Re: Review Request 34805: Patch for KAFKA-2213

2015-07-10 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- (Updated July 10, 2015, 2:50 p.m.) Review request for kafka. Bugs: KAFKA-2213

Re: Review Request 34805: Patch for KAFKA-2213

2015-06-17 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- (Updated June 17, 2015, 10:38 a.m.) Review request for kafka. Bugs: KAFKA-221

Re: Review Request 34805: Patch for KAFKA-2213

2015-06-17 Thread Manikumar Reddy O
> On June 16, 2015, 11:04 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, line 406 > > > > > > Can we now avoid this additional copy of retained messages by sending > > retained messages di

Re: Review Request 34805: Patch for KAFKA-2213

2015-06-16 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/#review88148 --- Thanks for the patch. clients/src/main/java/org/apache/kafka/commo

Re: Review Request 34805: Patch for KAFKA-2213

2015-05-29 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- (Updated May 29, 2015, 6:55 p.m.) Review request for kafka. Bugs: KAFKA-2213

Review Request 34805: Patch for KAFKA-2213

2015-05-29 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- Review request for kafka. Bugs: KAFKA-2213 https://issues.apache.org/jira/b