Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 25, 2015, 1:12 a.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 25, 2015, 1:11 a.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/#review92917 --- Ship it! Thanks for the patch. Looks good. +1 after addressing a fe

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:20 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:18 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:14 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:14 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

> On July 17, 2015, 4:43 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/ConfigHandler.scala, lines 64-65 > > > > > > Could we just use Pool? Nice.. didn't know about that util. - Aditya ---

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/#review92008 --- Thanks for the latest patch. Have a few more comments below. core/

Re: Review Request 34554: Patch for KAFKA-2205

> On July 9, 2015, 2:28 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/admin/ConfigCommand.scala, line 123 > > > > > > Could we list the valid configs name for each entity-type as we did in > > TopicCommand? I'

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 14, 2015, 5:37 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 14, 2015, 5:36 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 14, 2015, 5:34 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 34554: Patch for KAFKA-2205

> On July 9, 2015, 2:28 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/ConfigHandler.scala, line 27 > > > > > > Do we need JavaConversions? If this is needed, it would be better to > > import it in the con

Re: Review Request 34554: Patch for KAFKA-2205

> On July 7, 2015, 2:18 a.m., Jun Rao wrote: > > Thanks for the patch. A few more comments below. > > > > 1. The patch doesn't apply. Could you rebase? > > 2. Also, we need the logic to read all existing client configs. Is that in > > a separate jira? > > Aditya Auradkar wrote: > 1. Will d

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/#review91038 --- Thanks for the new patch. Just a couple of minor comments below. c

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 8, 2015, 2:13 a.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 8, 2015, 2:12 a.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 34554: Patch for KAFKA-2205

> On July 7, 2015, 2:18 a.m., Jun Rao wrote: > > Thanks for the patch. A few more comments below. > > > > 1. The patch doesn't apply. Could you rebase? > > 2. Also, we need the logic to read all existing client configs. Is that in > > a separate jira? 1. Will do. 2. Hey Jun - I didn't understa

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/#review90622 --- Thanks for the patch. A few more comments below. 1. The patch doesn

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 2, 2015, 1:39 a.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 34554: Patch for KAFKA-2205

> On June 27, 2015, 2:48 p.m., Jun Rao wrote: > > Thanks for the patch. A few comments below. > > > > We plan to add the AlterConfig/DescribeConfig requests. Will that be > > handled in a separate jira? Also, are the new requests format listed in the > > KIP? Yeah, I'm planning to tackle the

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 2, 2015, 1:38 a.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/#review89623 --- Thanks for the patch. A few comments below. We plan to add the Alte

Re: Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated May 21, 2015, 5:55 p.m.) Review request for kafka. Bugs: KAFKA-2205

Review Request 34554: Patch for KAFKA-2205

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- Review request for kafka. Bugs: KAFKA-2205 https://issues.apache.org/jira/b