Re: Review Request 34524: Fix KAFKA-2208

2015-06-02 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34524/#review86304 --- Ship it! I brought up a local vagrant cluster of 2 brokers, 1 zk no

Re: Review Request 34524: Fix KAFKA-2208

2015-06-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34524/ --- (Updated June 2, 2015, 9:07 p.m.) Review request for kafka. Bugs: KAFKA-2208

Re: Review Request 34524: Fix KAFKA-2208

2015-06-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34524/ --- (Updated June 2, 2015, 5:45 p.m.) Review request for kafka. Bugs: KAFKA-2208

Re: Review Request 34524: Fix KAFKA-2208

2015-06-02 Thread Guozhang Wang
> On June 2, 2015, 12:20 a.m., Onur Karaman wrote: > > It'd rather avoid mixing coordinator failover optimization logic with this > > rb. Can you undo the changes in ConsumerCoordinator.scala from line 214 > > down to the bottom of ConsumerCoordinator.scala? OK agreed. Revert the remove-group

Re: Review Request 34524: Fix KAFKA-2208

2015-06-01 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34524/#review86101 --- It'd rather avoid mixing coordinator failover optimization logic wit

Re: Review Request 34524: Fix KAFKA-2208

2015-05-31 Thread Guozhang Wang
> On May 28, 2015, 11:42 p.m., Onur Karaman wrote: > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines > > 98-133 > > > > > > Let's say a consumer sends a JoinGroupRequest for a new group g and

Re: Review Request 34524: Fix KAFKA-2208

2015-05-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34524/ --- (Updated June 1, 2015, 12:05 a.m.) Review request for kafka. Bugs: KAFKA-2208

Re: Review Request 34524: Fix KAFKA-2208

2015-05-28 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34524/#review85641 --- clients/src/main/java/org/apache/kafka/clients/consumer/internals/C

Re: Review Request 34524: Fix KAFKA-2208

2015-05-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34524/ --- (Updated May 21, 2015, 2:15 a.m.) Review request for kafka. Bugs: KAFKA-2208

Review Request 34524: Fix KAFKA-2208

2015-05-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34524/ --- Review request for kafka. Bugs: KAFKA-2208 https://issues.apache.org/jira/b