Re: Review Request 34450: Fix KAFKA-2017

2015-05-26 Thread Jun Rao
> On May 21, 2015, 12:16 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines > > 102-106 > > > > > > Another way to do this is to only load from ZK on the becoming leader >

Re: Review Request 34450: Fix KAFKA-2017

2015-05-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34450/ --- (Updated May 22, 2015, 2:03 a.m.) Review request for kafka. Bugs: KAFKA-2017

Re: Review Request 34450: Fix KAFKA-2017

2015-05-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34450/ --- (Updated May 22, 2015, 2:02 a.m.) Review request for kafka. Summary (updated)

Re: Review Request 34450: Fix KAFKA-2017; rebased

2015-05-21 Thread Guozhang Wang
> On May 21, 2015, 12:16 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines > > 102-106 > > > > > > Another way to do this is to only load from ZK on the becoming leader >

Re: Review Request 34450: Fix KAFKA-2017; rebased

2015-05-20 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34450/#review84604 --- Thanks for the patch. A few comments below. core/src/main/scala/ka

Re: Review Request 34450: Fix KAFKA-2017; rebased

2015-05-20 Thread Guozhang Wang
> On May 20, 2015, 5:15 p.m., Onur Karaman wrote: > > I only did a brief skim. This optimization tries to switch consumers over > > to a new coordinator without a rebalance. From my understanding, the > > consumers would detect a coordinator failure, discover the new coordinator > > to work wi

Re: Review Request 34450: Fix KAFKA-2017; rebased

2015-05-20 Thread Onur Karaman
> On May 20, 2015, 5:15 p.m., Onur Karaman wrote: > > I only did a brief skim. This optimization tries to switch consumers over > > to a new coordinator without a rebalance. From my understanding, the > > consumers would detect a coordinator failure, discover the new coordinator > > to work wi

Re: Review Request 34450: Fix KAFKA-2017; rebased

2015-05-20 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34450/#review84539 --- I only did a brief skim. This optimization tries to switch consumers

Re: Review Request 34450: Fix KAFKA-2017; rebased

2015-05-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34450/ --- (Updated May 20, 2015, 4:13 p.m.) Review request for kafka. Summary (updated)