Re: Review Request 34418: Patch for KAFKA-2191

2015-05-20 Thread Dong Lin
> On May 19, 2015, 5:41 p.m., Dong Lin wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line > > 64 > > > > > > Hey Jay, > > > > My approach differs with your only in this line

Re: Review Request 34418: Patch for KAFKA-2191

2015-05-19 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34418/#review84349 --- clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.ja

Re: Review Request 34418: Patch for KAFKA-2191

2015-05-19 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34418/#review84344 --- Looks good. minor comment clients/src/main/java/org/apache/kafka/c

Review Request 34418: Patch for KAFKA-2191

2015-05-19 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34418/ --- Review request for kafka. Bugs: KAFKA-2191 https://issues.apache.org/jira/b