Re: Review Request 33645: Patch for KAFKA-2153

2015-05-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/#review82406 --- Ship it! Ship It! - Neha Narkhede On April 28, 2015, 11:04 p.m.,

Re: Review Request 33645: Patch for KAFKA-2153

2015-04-29 Thread Ashish Singh
> On April 30, 2015, 12:50 a.m., Gwen Shapira wrote: > > Thanks for fixing the review tool! > > > > It looks like some changes to test-patch.py are included. Can you clean > > them out if they are not an intentional part of this patch? They are intentional :). I am reusing the part of logic al

Re: Review Request 33645: Patch for KAFKA-2153

2015-04-29 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/#review82076 --- Thanks for fixing the review tool! It looks like some changes to te

Review Request 33645: Patch for KAFKA-2153

2015-04-28 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/ --- Review request for kafka. Bugs: KAFKA-2153 https://issues.apache.org/jira/b