Re: Review Request 33557: Patch for KAFKA-1936

> On May 12, 2015, 2:45 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaRequestHandler.scala, line 147 > > > > > > Just a minor naming comment: these `mark*Rate` methods can just be > > called `rec

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/ --- (Updated May 12, 2015, 3:02 p.m.) Review request for kafka. Bugs: KAFKA-1936

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review83398 --- Ship it! core/src/main/scala/kafka/server/KafkaRequestHandler.scal

Re: Review Request 33557: Patch for KAFKA-1936

> On May 11, 2015, 5:25 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaRequestHandler.scala, line 147 > > > > > > How about > > markBrokerTopicMeters > > or > > updateBrokerTopicStats > >

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/ --- (Updated May 12, 2015, 2:32 p.m.) Review request for kafka. Bugs: KAFKA-1936

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review83234 --- core/src/main/scala/kafka/server/KafkaRequestHandler.scala

Re: Review Request 33557: Patch for KAFKA-1936

> On May 4, 2015, 5:18 p.m., Joel Koshy wrote: > > This looks good overall. Couple of questions: > > - You have blacklisted the topic for recording in the global broker topic > > metrics, but for consistency should we do this for per-topic metrics as > > well? > > - Rather than do the topic che

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/ --- (Updated May 4, 2015, 10:18 p.m.) Review request for kafka. Bugs: KAFKA-1936

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review82392 --- This looks good overall. Couple of questions: - You have blacklisted

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review81657 --- Ship it! Ship It! - Jiangjie Qin On April 27, 2015, 4:26 a.m., D

Re: Review Request 33557: Patch for KAFKA-1936

> On April 27, 2015, 4 a.m., Jiangjie Qin wrote: > > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala, line 107 > > > > > > Typo, larger. Thanks for noticing the bytes-out-rate and the typo. I missed that

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/ --- (Updated April 27, 2015, 4:26 a.m.) Review request for kafka. Bugs: KAFKA-193

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/ --- (Updated April 27, 2015, 4:20 a.m.) Review request for kafka. Bugs: KAFKA-193

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review81654 --- Should we also apply the same rule to bytes out rate? core/src/tes

Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/ --- Review request for kafka. Bugs: KAFKA-1936 https://issues.apache.org/jira/b