Re: Review Request 33168: Fix recovery of swap files after broker crash

2015-04-19 Thread Rajini Sivaram
> On April 17, 2015, 10:44 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 775-777 > > > > > > It's not clear what "this operation" is. It seems to refer to > > replaceSegments(), bit replaceSe

Re: Review Request 33168: Fix recovery of swap files after broker crash

2015-04-19 Thread Rajini Sivaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33168/ --- (Updated April 19, 2015, 7:03 p.m.) Review request for kafka. Bugs: KAFKA-211

Re: Review Request 33168: Fix recovery of swap files after broker crash

2015-04-17 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33168/#review80543 --- Thanks for the patch. Great finding and very comprehensive tests! Ju

Re: Review Request 33168: Fix recovery of swap files after broker crash

2015-04-15 Thread Rajini Sivaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33168/ --- (Updated April 15, 2015, 9:44 a.m.) Review request for kafka. Bugs: KAFKA-211

Review Request 33168: Fix recovery of swap files after broker crash

2015-04-14 Thread Rajini Sivaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33168/ --- Review request for kafka. Bugs: KAFKA-2118 https://issues.apache.org/jira/b