Re: Review Request 31606: Patch for KAFKA-1416

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/#review80122 --- Ship it! Ship It! - Guozhang Wang On April 11, 2015, 1:36 a.m.,

Re: Review Request 31606: Patch for KAFKA-1416

> On March 25, 2015, 9:51 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/integration/FetcherTest.scala, line 85 > > > > > > Import TestUtils.sendMessages It seems that this is a practice from all committ

Re: Review Request 31606: Patch for KAFKA-1416

> On April 8, 2015, 9:56 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 794 > > > > > > "Default Partition: use the topic string as the key to determine the > > partition"

Re: Review Request 31606: Patch for KAFKA-1416

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/ --- (Updated April 11, 2015, 1:36 a.m.) Review request for kafka. Bugs: KAFKA-141

Re: Review Request 31606: Patch for KAFKA-1416

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/#review79438 --- core/src/test/scala/unit/kafka/integration/FetcherTest.scala

Re: Review Request 31606: Patch for KAFKA-1416

> On March 25, 2015, 9:51 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, lines 761-773 > > > > > > Compression code is no longer used anymore, which seems not correct? > > Flutra

Re: Review Request 31606: Patch for KAFKA-1416

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/ --- (Updated March 26, 2015, 7:21 a.m.) Review request for kafka. Bugs: KAFKA-141

Re: Review Request 31606: Patch for KAFKA-1416

> On March 25, 2015, 9:51 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala, > > lines 85-106 > > > > > > Can we use TestUtils.sendMessages to replace t

Re: Review Request 31606: Patch for KAFKA-1416

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/#review77804 --- core/src/test/scala/unit/kafka/integration/FetcherTest.scala

Re: Review Request 31606: Patch for KAFKA-1416

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/ --- (Updated March 2, 2015, 1:25 a.m.) Review request for kafka. Bugs: KAFKA-1416

Review Request 31606: Patch for KAFKA-1416

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/ --- Review request for kafka. Bugs: KAFKA-1416 https://issues.apache.org/jira/b