Re: Review Request 31199: Patch for KAFKA-1965

2015-02-20 Thread Yasuhiro Matsuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31199/ --- (Updated Feb. 20, 2015, 11:08 p.m.) Review request for kafka. Bugs: KAFKA-196

Re: Review Request 31199: Patch for KAFKA-1965

2015-02-19 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31199/#review73253 --- Ship it! Other than the minor renaming comment, the patch LGTM. I c

Re: Review Request 31199: Patch for KAFKA-1965

2015-02-19 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31199/#review73168 --- Ship it! minor comment. core/src/main/scala/kafka/utils/DelayedIt

Review Request 31199: Patch for KAFKA-1965

2015-02-19 Thread Yasuhiro Matsuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31199/ --- Review request for kafka. Bugs: KAFKA-1965 https://issues.apache.org/jira/b