Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jay Kreps
> On Feb. 23, 2015, 5 a.m., Jiangjie Qin wrote: > > clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java, > > line 210 > > > > > > It probably does not matter, but here we are only sendin

Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jay Kreps
> On Feb. 23, 2015, 8:53 p.m., Jiangjie Qin wrote: > > Hi Jay, I applied the patch and tried to run it in our test environment. I > > got this exception: > > > > java.util.ConcurrentModificationException > > at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429) > > at ja

Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jay Kreps
> On Feb. 23, 2015, 6:44 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 376 > > > > > > Add @throws KafkaException I added the other exceptions I k

Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jiangjie Qin
> On Feb. 23, 2015, 8:53 p.m., Jiangjie Qin wrote: > > Hi Jay, I applied the patch and tried to run it in our test environment. I > > got this exception: > > > > java.util.ConcurrentModificationException > > at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429) > > at ja

Re: Review Request 30763: Second attempt at flush()

2015-02-23 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review73665 --- Hi Jay, I applied the patch and tried to run it in our test environm

Re: Review Request 30763: Second attempt at flush()

2015-02-22 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review73475 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

Re: Review Request 30763: Second attempt at flush()

2015-02-22 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review73505 --- Ship it! Thanks Jay. Looks good to me. Just a minor comment. clie

Re: Review Request 30763: Second attempt at flush()

2015-02-22 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 23, 2015, 12:26 a.m.) Review request for kafka. Summary (update