Re: Review Request 30763: Patch for KAFKA-1865

> On Feb. 22, 2015, 2:46 a.m., Jiangjie Qin wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, > > line 90 > > > > > > It seems we haven't update the produce result here yet.

Re: Review Request 30763: Patch for KAFKA-1865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review73433 --- Thanks Jay, just one comment below. clients/src/main/java/org/apac

Re: Review Request 30763: Patch for KAFKA-1865

> On Feb. 17, 2015, 11:46 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 400 > > > > > > Indentation? Looks right to me... > On Feb. 17, 2015, 11:46 p.m., Guozhang Wang wro

Re: Review Request 30763: Patch for KAFKA-1865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 21, 2015, 11:37 p.m.) Review request for kafka. Bugs: KAFKA-186

Re: Review Request 30763: Patch for KAFKA-1865

> On Feb. 8, 2015, 7:04 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 352 > > > > > > This isn't properly reset in the case o

Re: Review Request 30763: Patch for KAFKA-1865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review72821 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

Re: Review Request 30763: Patch for KAFKA-1865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review72794 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 30763: Patch for KAFKA-1865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review71573 --- Minor issue with cleaning an InterruptionException, but otherwise lo

Review Request 30763: Patch for KAFKA-1865

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- Review request for kafka. Bugs: KAFKA-1865 https://issues.apache.org/jira/b