Re: Review Request 30763: KAFKA-1865: add flush to producer

> On Feb. 26, 2015, 7:15 p.m., Jun Rao wrote: > > clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java, > > line 87 > > > > > > Do we really want to print the stack trace? > > Jay Kreps wrote: >

Re: Review Request 30763: KAFKA-1865: add flush to producer

> On Feb. 26, 2015, 7:15 p.m., Jun Rao wrote: > > clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java, > > line 87 > > > > > > Do we really want to print the stack trace? > > Jay Kreps wrote: >

Re: Review Request 30763: KAFKA-1865: add flush to producer

> On Feb. 26, 2015, 7:15 p.m., Jun Rao wrote: > > clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java, > > line 87 > > > > > > Do we really want to print the stack trace? I think so, we are not e

Re: Review Request 30763: KAFKA-1865: add flush to producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review74332 --- Ship it! Looks good to me. Just a couple of minor comments. clien

Re: Review Request 30763: KAFKA-1865: add flush to producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 26, 2015, 6:40 p.m.) Review request for kafka. Bugs: KAFKA-1865

Re: Review Request 30763: KAFKA-1865: add flush to producer

> On Feb. 24, 2015, 5:20 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, > > line 91 > > > > > > I still think it is kind of waste to create duplicate

Re: Review Request 30763: KAFKA-1865: add flush to producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 26, 2015, 6:37 p.m.) Review request for kafka. Summary (updated

Re: Review Request 30763: KAFKA-1865: add flush to producer

> On Feb. 17, 2015, 9:28 p.m., Jiangjie Qin wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, > > line 80 > > > > > > I think we have to execute the callback before we wake