Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

> On Feb. 26, 2015, 7:14 a.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java, > > line 132 > > > > > > synchronized no longer matches the regular non-Mock v

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

> On Feb. 26, 2015, 5:47 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 503 > > > > > > Not sure how we make sure only a single flush at a time. Could you

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review74229 --- clients/src/main/java/org/apache/kafka/clients/producer/MockProduce

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

> On Feb. 24, 2015, 5:20 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, > > line 91 > > > > > > I still think it is kind of waste to create duplicate

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review74196 --- Thanks for the patch. A few comments below. clients/src/main/java/

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 26, 2015, 1:16 a.m.) Review request for kafka. Bugs: KAFKA-1865

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 26, 2015, 1:15 a.m.) Review request for kafka. Summary (updated