Re: Review Request 30547: Integrate checkstyle.

2015-02-03 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30547/#review70911 --- Ship it! Ship It! - Joel Koshy On Feb. 3, 2015, 5:17 p.m., Jay K

Re: Review Request 30547: Integrate checkstyle.

2015-02-03 Thread Joel Koshy
> On Feb. 3, 2015, 7:44 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java, > > line 45 > > > > > > Wondering why LOCK needs to be all-capitalized while Log above does

Re: Review Request 30547: Integrate checkstyle.

2015-02-03 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30547/ --- (Updated Feb. 3, 2015, 5:17 p.m.) Review request for kafka. Bugs: KAFKA-1915

Re: Review Request 30547: Integrate checkstyle.

2015-02-03 Thread Jay Kreps
> On Feb. 3, 2015, 7:20 a.m., Joel Koshy wrote: > > build.gradle, line 387 > > > > > > Is the consequence of violations this going to be a warning or an error > > or a report? Either way is there a way to suppress it

Re: Review Request 30547: Integrate checkstyle.

2015-02-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30547/#review70713 --- build.gradle

Re: Review Request 30547: Integrate checkstyle.

2015-02-02 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30547/#review70712 --- Looks like a useful tool. build.gradle

Review Request 30547: Integrate checkstyle.

2015-02-02 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30547/ --- Review request for kafka. Bugs: KAFKA-1915 https://issues.apache.org/jira/b