Re: Review Request 30126: Patch for KAFKA-1845

2015-03-04 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30126/ --- (Updated March 4, 2015, 11:12 p.m.) Review request for kafka. Bugs: KAFKA-184

Re: Review Request 30126: Patch for KAFKA-1845

2015-02-08 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30126/ --- (Updated Feb. 8, 2015, 3:05 p.m.) Review request for kafka. Bugs: KAFKA-1845

Re: Review Request 30126: Patch for KAFKA-1845

2015-02-04 Thread Andrii Biletskyi
> On Jan. 22, 2015, 7:57 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 743-758 > > > > > > This looks fairly generic. Shouldn't it be somewhere where it can be > > reused by o

Re: Review Request 30126: Patch for KAFKA-1845

2015-02-04 Thread Andrii Biletskyi
> On Feb. 3, 2015, 2:06 p.m., Jeff Holoman wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 834 > > > > > > Is this is the right way to do this rather than having these in > > Validators? Some of t

Re: Review Request 30126: Patch for KAFKA-1845

2015-02-03 Thread Joe Stein
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30126/#review70747 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Re: Review Request 30126: Patch for KAFKA-1845

2015-02-03 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30126/#review70748 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Re: Review Request 30126: Patch for KAFKA-1845

2015-02-03 Thread Andrii Biletskyi
> On Jan. 21, 2015, 10:55 p.m., Eric Olander wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 130 > > > > > > It seems that by convention there is a ...Prop and a ...Doc constant, > > but nothing en

Re: Review Request 30126: Patch for KAFKA-1845

2015-01-22 Thread Gwen Shapira
> On Jan. 21, 2015, 10:55 p.m., Eric Olander wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 475 > > > > > > Maybe some helper functions could help with this code: > > > > def stringProp(pr

Re: Review Request 30126: Patch for KAFKA-1845

2015-01-22 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30126/#review69224 --- Looks great. Just one minor comment. core/src/main/scala/kafka/ser

Re: Review Request 30126: Patch for KAFKA-1845

2015-01-21 Thread Eric Olander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30126/#review69063 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Review Request 30126: Patch for KAFKA-1845

2015-01-21 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30126/ --- Review request for kafka. Bugs: KAFKA-1845 https://issues.apache.org/jira/b