Re: Review Request 29752: Patch for KAFKA-1836

2015-01-09 Thread Jaikiran Pai
> On Jan. 9, 2015, 5:51 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java, > > line 110 > > > > > > This works since the check farther down ensures

Re: Review Request 29752: Patch for KAFKA-1836

2015-01-09 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29752/ --- (Updated Jan. 10, 2015, 2:57 a.m.) Review request for kafka. Bugs: KAFKA-1836

Re: Review Request 29752: Patch for KAFKA-1836

2015-01-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29752/#review67466 --- Ship it! Looks good other than what Ewen pointed out. - Neha Narkh

Re: Review Request 29752: Patch for KAFKA-1836

2015-01-09 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29752/#review67457 --- Ship it! One minor nit, but looks good to me. Non-binding +1. cli

Review Request 29752: Patch for KAFKA-1836

2015-01-08 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29752/ --- Review request for kafka. Bugs: KAFKA-1836 https://issues.apache.org/jira/b