Re: Review Request 29714: Patch for KAFKA-1810

2015-03-14 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/ --- (Updated March 15, 2015, 5:26 a.m.) Review request for kafka. Bugs: KAFKA-181

Re: Review Request 29714: Patch for KAFKA-1810

2015-03-14 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/#review76500 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Re: Review Request 29714: Patch for KAFKA-1810

2015-03-14 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/ --- (Updated March 15, 2015, 5:13 a.m.) Review request for kafka. Bugs: KAFKA-181

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-16 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/#review68440 --- Looks awesome. Great tests. Two things: 1. The patch no longer appl

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-16 Thread Jeff Holoman
> On Jan. 16, 2015, 1:55 p.m., Eric Olander wrote: > > core/src/test/scala/unit/kafka/network/IPFilterTest.scala, line 71 > > > > > > This is more an FYI as it may go against established practices for > > tests in this

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-16 Thread Eric Olander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/#review68424 --- core/src/main/scala/kafka/network/IPFilter.scala

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-15 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/ --- (Updated Jan. 16, 2015, 12:48 a.m.) Review request for kafka. Bugs: KAFKA-181

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-15 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/ --- (Updated Jan. 16, 2015, 12:47 a.m.) Review request for kafka. Bugs: KAFKA-181

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-09 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/#review67573 --- core/src/main/scala/kafka/network/SocketServer.scala

Re: Review Request 29714: Patch for KAFKA-1810

2015-01-08 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/ --- (Updated Jan. 8, 2015, 7:14 p.m.) Review request for kafka. Bugs: KAFKA-1810

Review Request 29714: Patch for KAFKA-1810

2015-01-08 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/ --- Review request for kafka. Bugs: KAFKA-1810 https://issues.apache.org/jira/b