Re: Review Request 29379: Patch for KAFKA-1788

2015-02-22 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/#review73512 --- Minor comments, I think the biggest issue remaining is getting Send

Re: Review Request 29379: Patch for KAFKA-1788

2015-02-22 Thread Ewen Cheslack-Postava
> On Jan. 6, 2015, 6:43 p.m., Parth Brahmbhatt wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 225 > > > > > > sender.completeBatch() is only called as par

Re: Review Request 29379: Patch for KAFKA-1788

2015-01-06 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/#review66942 --- Thinking about this more, I think this patch only covers one very sp

Re: Review Request 29379: Patch for KAFKA-1788

2015-01-06 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/ --- (Updated Jan. 6, 2015, 6:44 p.m.) Review request for kafka. Bugs: KAFKA-1788

Re: Review Request 29379: Patch for KAFKA-1788

2015-01-06 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/#review66879 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 29379: Patch for KAFKA-1788

2015-01-06 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/ --- (Updated Jan. 6, 2015, 6:42 p.m.) Review request for kafka. Bugs: KAFKA-1788

Re: Review Request 29379: Patch for KAFKA-1788

2015-01-05 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/#review66709 --- I think the basic approach in this patch looks sound and should work

Re: Review Request 29379: Patch for KAFKA-1788

2014-12-23 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/ --- (Updated Dec. 23, 2014, 8:44 p.m.) Review request for kafka. Changes ---

Review Request 29379: Patch for KAFKA-1788

2014-12-23 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/ --- Review request for kafka. Bugs: KAFKA-1788 https://issues.apache.org/jira/b