Re: Review Request 29301: Patch for KAFKA-1694

> On Feb. 3, 2015, 7:14 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, line 44 > > > > > > How about just augmenting OFFSET_FETCH request to return offsets > > commi

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- (Updated March 12, 2015, 11:04 a.m.) Review request for kafka. Bugs: KAFKA-16

Re: Review Request 29301: Patch for KAFKA-1694

> On Feb. 3, 2015, 7:14 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/TopicCommandHelper.scala, lines 1-17 > > > > > > One general comment: > > > > For some topic commands, why use AdminUtils t

Re: Review Request 29301: Patch for KAFKA-1694

> On Feb. 3, 2015, 7:14 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/TopicCommandHelper.scala, lines 1-17 > > > > > > One general comment: > > > > For some topic commands, why use AdminUtils t

Re: Review Request 29301: Patch for KAFKA-1694

> On Feb. 3, 2015, 7:14 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, lines > > 39-42 > > > > > > How about merge them into one request? The format could be: > >

Re: Review Request 29301: Patch for KAFKA-1694

> On Feb. 3, 2015, 7:14 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, lines > > 39-42 > > > > > > How about merge them into one request? The format could be: > >

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/#review70790 --- Looks good overall. Some comments below, which did not cover the cli

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- (Updated Jan. 14, 2015, 4:07 p.m.) Review request for kafka. Bugs: KAFKA-1694

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- (Updated Jan. 14, 2015, 1:42 p.m.) Review request for kafka. Bugs: KAFKA-1694

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- (Updated Jan. 13, 2015, 5:30 p.m.) Review request for kafka. Bugs: KAFKA-1694

Re: Review Request 29301: Patch for KAFKA-1694

> On Jan. 6, 2015, 8:19 a.m., Joe Stein wrote: > > build.gradle, line 211 > > > > > > If we can do this without an upgrade that would be great if we are in > > fact just requiring 1 function. This feature allows us t

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- (Updated Jan. 12, 2015, 4:55 p.m.) Review request for kafka. Bugs: KAFKA-1694

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- (Updated Jan. 12, 2015, 1:28 p.m.) Review request for kafka. Bugs: KAFKA-1694

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/#review66838 --- tools/src/main/java/org/apache/kafka/cli/command/AlterTopicCommand.

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/#review66801 --- build.gradle

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- (Updated Dec. 24, 2014, 7:22 p.m.) Review request for kafka. Bugs: KAFKA-1694

Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- Review request for kafka. Bugs: KAFKA-1694 https://issues.apache.org/jira/b