Re: Review Request 29029: Patch for KAFKA-1512

2014-12-29 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/#review66324 --- Ship it! Ship It! - Jay Kreps On Dec. 24, 2014, 2:47 a.m., Jeff

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/#review66134 --- Ship it! Non-binding +1 - the fix and test look good. - Gwen Shapi

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-23 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/ --- (Updated Dec. 24, 2014, 2:47 a.m.) Review request for kafka. Bugs: KAFKA-1512

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-23 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/ --- (Updated Dec. 24, 2014, 2:24 a.m.) Review request for kafka. Bugs: KAFKA-1512

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-15 Thread Jeff Holoman
> On Dec. 15, 2014, 7:58 p.m., Gwen Shapira wrote: > > Jeff, > > > > There's some strange things going on there, I think we need a bit more > > testing and maybe more implementation :) > > > > 1. Please make sure the test fails without the override fix. When I tried, > > it passed on trunk...

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-15 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/#review65114 --- Jeff, There's some strange things going on there, I think we need a

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-14 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/ --- (Updated Dec. 15, 2014, 2:30 a.m.) Review request for kafka. Bugs: KAFKA-1512

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-14 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/ --- (Updated Dec. 15, 2014, 2:21 a.m.) Review request for kafka. Bugs: KAFKA-1512

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-14 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/ --- (Updated Dec. 15, 2014, 2:16 a.m.) Review request for kafka. Summary (updated