Re: Review Request 28859: Patch for KAFKA-1812

2014-12-10 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28859/#review64689 --- Ship it! Non-binding +1 - Gwen Shapira On Dec. 11, 2014, 2:39 a.

Re: Review Request 28859: Patch for KAFKA-1812

2014-12-10 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28859/ --- (Updated Dec. 11, 2014, 2:39 a.m.) Review request for kafka. Bugs: KAFKA-1812

Re: Review Request 28859: Patch for KAFKA-1812

2014-12-10 Thread Gwen Shapira
> On Dec. 10, 2014, 3:21 p.m., Gwen Shapira wrote: > > Non-binding LGTM from me. > > > > Any chance of cleaning up the whitespace? makes the change looks way bigger > > than it really is. > > > > Few suggested improvements below: My mistake - the whitespaces were in the code originally and th

Re: Review Request 28859: Patch for KAFKA-1812

2014-12-10 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28859/#review64546 --- Non-binding LGTM from me. Any chance of cleaning up the whitespace?

Review Request 28859: Patch for KAFKA-1812

2014-12-09 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28859/ --- Review request for kafka. Bugs: KAFKA-1812 https://issues.apache.org/jira/b