Re: Review Request 28096: Patch for KAFKA-313

2015-08-12 Thread Ashish Singh
> On July 29, 2015, 6:35 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, lines 237-242 > > > > > > These look identical - copy/paste error? > > Ashish Singh wrote: > Not r

Re: Review Request 28096: Patch for KAFKA-313

2015-08-12 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated Aug. 12, 2015, 9:21 p.m.) Review request for kafka, Gwen Shapira, Jare

Re: Review Request 28096: Patch for KAFKA-313

2015-08-10 Thread Gwen Shapira
> On July 29, 2015, 6:35 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, lines 237-242 > > > > > > These look identical - copy/paste error? > > Ashish Singh wrote: > Not r

Re: Review Request 28096: Patch for KAFKA-313

2015-08-10 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated Aug. 10, 2015, 7:58 p.m.) Review request for kafka, Gwen Shapira, Jare

Re: Review Request 28096: Patch for KAFKA-313

2015-08-07 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/#review94522 --- core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala (line 10

Re: Review Request 28096: Patch for KAFKA-313

2015-08-05 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated Aug. 5, 2015, 10:43 p.m.) Review request for kafka, Gwen Shapira, Jare

Re: Review Request 28096: Patch for KAFKA-313

2015-08-05 Thread Ashish Singh
> On July 29, 2015, 6:35 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, lines 36-39 > > > > > > Shouldn't this be an inner object? since its only visible and used by > > Consu

Re: Review Request 28096: Patch for KAFKA-313

2015-08-05 Thread Ashish Singh
> On July 30, 2015, 2:11 p.m., Ismael Juma wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, line 45 > > > > > > Do we really need this var or can this be passed as a parameter to the > > relevant

Re: Review Request 28096: Patch for KAFKA-313

2015-08-05 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated Aug. 5, 2015, 10:37 p.m.) Review request for kafka, Gwen Shapira, Jare

Re: Review Request 28096: Patch for KAFKA-313

2015-07-30 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/#review93559 --- core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala (line 45

Re: Review Request 28096: Patch for KAFKA-313

2015-07-29 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/#review93489 --- Thanks for the patch and sorry for the long delay. core/src/main/s

Re: Review Request 28096: Patch for KAFKA-313

2015-06-24 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated June 24, 2015, 6:14 p.m.) Review request for kafka, Gwen Shapira, Jare

Re: Review Request 28096: Patch for KAFKA-313

2015-02-23 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated Feb. 24, 2015, 2:11 a.m.) Review request for kafka, Gwen Shapira, Jare