Re: Review Request 27890: Patch for KAFKA-1764

2014-11-13 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27890/ --- (Updated Nov. 14, 2014, 7:57 a.m.) Review request for kafka. Bugs: KAFKA-1764

Re: Review Request 27890: Patch for KAFKA-1764

2014-11-13 Thread Joel Koshy
> On Nov. 14, 2014, 1:50 a.m., Joel Koshy wrote: > > It should be easy to reproduce this in the existing unit test right? and > > then verify that it works? nm - discussed offline. This is hard to reproduce since the offer needs to happen between the clear and put. - Joel -

Re: Review Request 27890: Patch for KAFKA-1764

2014-11-13 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27890/#review61374 --- Ship it! It should be easy to reproduce this in the existing unit t

Re: Review Request 27890: Patch for KAFKA-1764

2014-11-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27890/#review61099 --- Ship it! Ship It! - Guozhang Wang On Nov. 12, 2014, 10:05 p.m.,

Re: Review Request 27890: Patch for KAFKA-1764

2014-11-12 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27890/ --- (Updated Nov. 12, 2014, 10:05 p.m.) Review request for kafka. Bugs: KAFKA-176

Re: Review Request 27890: Patch for KAFKA-1764

2014-11-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27890/#review61001 --- Could you also remove the line in consumer that sends back the shutd

Review Request 27890: Patch for KAFKA-1764

2014-11-11 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27890/ --- Review request for kafka. Bugs: KAFKA-1764 https://issues.apache.org/jira/b