Re: Review Request 27799: Patch for KAFKA-1760

2015-01-21 Thread Jay Kreps
> On Jan. 13, 2015, 10:32 p.m., Onur Karaman wrote: > > clients/src/main/java/org/apache/kafka/clients/ClientRequest.java, lines > > 34-37 > > > > > > It looks like you'd want to replace the attachment docs with new >

Re: Review Request 27799: Patch for KAFKA-1760

2015-01-21 Thread Jay Kreps
> On Jan. 20, 2015, 6:11 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/Cluster.java, line 1 > > > > > > Wondering if we should create a new "metadata" sub-directory of common, > > and move

Re: Review Request 27799: Patch for KAFKA-1760

2015-01-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/#review68699 --- clients/src/main/java/org/apache/kafka/clients/consumer/internals/H

Re: Review Request 27799: Patch for KAFKA-1760

2015-01-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/#review68693 --- clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.

Re: Review Request 27799: Patch for KAFKA-1760

2015-01-19 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/#review68519 --- clients/src/main/java/org/apache/kafka/clients/RequestCompletionHan

Re: Review Request 27799: Patch for KAFKA-1760

2015-01-18 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/ --- (Updated Jan. 19, 2015, 3:10 a.m.) Review request for kafka. Bugs: KAFKA-1760

Re: Review Request 27799: Patch for KAFKA-1760

2015-01-13 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/#review67959 --- clients/src/main/java/org/apache/kafka/clients/ClientRequest.java <

Re: Review Request 27799: Patch for KAFKA-1760

2015-01-11 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/ --- (Updated Jan. 12, 2015, 12:57 a.m.) Review request for kafka. Summary (update