Re: Review Request 26658: Patch for KAFKA-1493

2014-10-16 Thread James Oliver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26658/ --- (Updated Oct. 17, 2014, 4:25 a.m.) Review request for kafka. Bugs: KAFKA-1493

Re: Review Request 26658: Patch for KAFKA-1493

2014-10-16 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26658/#review57005 --- Thanks for the patch. Looks good overall. Some minor comments below.

Re: Review Request 26658: Patch for KAFKA-1493

2014-10-16 Thread James Oliver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26658/ --- (Updated Oct. 16, 2014, 8:50 p.m.) Review request for kafka. Bugs: KAFKA-1493

Re: Review Request 26658: Patch for KAFKA-1493

2014-10-16 Thread James Oliver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26658/ --- (Updated Oct. 16, 2014, 8:49 p.m.) Review request for kafka. Bugs: KAFKA-1493

Review Request 26658: Patch for KAFKA-1493

2014-10-13 Thread James Oliver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26658/ --- Review request for kafka. Bugs: KAFKA-1493 https://issues.apache.org/jira/b