Re: Review Request 26107: Patch for KAFKA-1577

2014-09-26 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26107/#review54764 --- Ship it! Ship It! - Joel Koshy On Sept. 27, 2014, 2:13 a.m., Sri

Re: Review Request 26107: Patch for KAFKA-1577

2014-09-26 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26107/ --- (Updated Sept. 27, 2014, 2:13 a.m.) Review request for kafka. Bugs: KAFKA-157

Re: Review Request 26107: Patch for KAFKA-1577

2014-09-26 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26107/#review54760 --- Looks good - we can now actually get rid of the swallowError when ca

Re: Review Request 26107: Patch for KAFKA-1577

2014-09-26 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26107/#review54755 --- Ship it! Ship It! - Neha Narkhede On Sept. 26, 2014, 10:41 p.m.,

Review Request 26107: Patch for KAFKA-1577

2014-09-26 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26107/ --- Review request for kafka. Bugs: KAFKA-1577 https://issues.apache.org/jira/b