Re: Review Request 24676: WIP KAFKA-1583

> On Aug. 25, 2014, 1:15 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 50-62 > > > > > > Should these two classes be in ReplicaManager since they are only used > > there? I originally put the

Re: Review Request 24676: WIP KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review51353 --- Thanks for the patch. Overall, this is a really nice cleanup patch.

Re: Review Request 24676: WIP KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Aug. 21, 2014, 6:33 p.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: WIP KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Aug. 21, 2014, 6:30 p.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: WIP KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Aug. 20, 2014, 9 p.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: WIP KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Aug. 20, 2014, 8:55 p.m.) Review request for kafka. Summary (updated