Re: Review Request 24676: Fix KAFKA-1583

> On Oct. 31, 2014, 6:08 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, line 236 > > > > > > Could we get rid of = since this method is supposed to not return any > > value? Thanks Jun.

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review59370 --- Just one minor comment. Perhaps we can address it in a future patch.

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review59109 --- Ship it! Ship It! - Joel Koshy On Oct. 28, 2014, 10:09 p.m., Guo

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Oct. 28, 2014, 10:09 p.m.) Review request for kafka. Bugs: KAFKA-158

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review58865 --- Ship it! Looks good - just minor comments which we can fix on check

Re: Review Request 24676: Fix KAFKA-1583

> On Oct. 22, 2014, 1:46 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 120 > > > > > > (for regular consumer fetch) > > Guozhang Wang wrote: > Actually this is for both c

Re: Review Request 24676: Fix KAFKA-1583

> On Oct. 22, 2014, 1:46 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, line 245 > > > > > > Maybe use this: > > "Recorded replica %d log end offset (LEO)..." > > > > Also,

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Oct. 23, 2014, 1:53 a.m.) Review request for kafka. Summary (updated

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review57147 --- Thanks for the patch. A few more comments. core/src/main/scala/kaf

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Oct. 17, 2014, 4:15 a.m.) Review request for kafka. Summary (updated

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Sept. 5, 2014, 9:55 p.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Sept. 5, 2014, 9:08 p.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: Fix KAFKA-1583

> On Sept. 3, 2014, 6:23 p.m., Jun Rao wrote: > > Looks good. I only have the following minor comments. Thanks Jun. If there is no more comments for now I will wait for KAFKA-1616 to be checked in first, and then do the rebase and the class / function renaming (which will make the diff file qu

Re: Review Request 24676: Fix KAFKA-1583

> On Sept. 3, 2014, 6:23 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/DelayedFetch.scala, line 100 > > > > > > Should we log topicAndPartition as well? fetchMetadata includes the fetchPartitionStatus, tha

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review52092 --- Looks good. I only have the following minor comments. core/src/mai

Re: Review Request 24676: Fix KAFKA-1583

> On Sept. 2, 2014, 5:53 p.m., Jun Rao wrote: > > Are you including the changes in kafka-1616 too? That would be fine. > > However, the comments in the other jira also need to be addressed in this > > patch. I was not intending to include the changes of KAFKA-1616. The plan is to first check

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Sept. 2, 2014, 8:37 p.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review52044 --- Are you including the changes in kafka-1616 too? That would be fine.

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Sept. 2, 2014, 1:09 a.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Sept. 2, 2014, 1:07 a.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: Fix KAFKA-1583

> On Aug. 29, 2014, 1:42 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 725 > > > > > > Do we need to add the new parameter? Does it hurt to write the > > checkpoint file in uni

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review51895 --- core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review51855 --- core/src/main/scala/kafka/cluster/Partition.scala

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Aug. 27, 2014, 5 p.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Aug. 27, 2014, 4:44 p.m.) Review request for kafka. Summary (updated