Re: Review Request 23858: Patch for KAFKA-1544

2014-07-24 Thread Manikumar Reddy O
> On July 23, 2014, 4:56 p.m., Jay Kreps wrote: > > Is this better than using a condition? I was imagining replacing sleep with > > shutdownCondition.await(backoffMs, TimeUnit.MILLISECONDS) and then in > > shutdown() we call shutdownCondition.signal(). > > Jay Kreps wrote: > Actually a con

Re: Review Request 23858: Patch for KAFKA-1544

2014-07-24 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23858/ --- (Updated July 24, 2014, 3:11 p.m.) Review request for kafka. Bugs: KAFKA-1544

Re: Review Request 23858: Patch for KAFKA-1544

2014-07-23 Thread Jay Kreps
> On July 23, 2014, 4:56 p.m., Jay Kreps wrote: > > Is this better than using a condition? I was imagining replacing sleep with > > shutdownCondition.await(backoffMs, TimeUnit.MILLISECONDS) and then in > > shutdown() we call shutdownCondition.signal(). Actually a condition isn't quite right as

Re: Review Request 23858: Patch for KAFKA-1544

2014-07-23 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23858/#review48532 --- Is this better than using a condition? I was imagining replacing sle

Review Request 23858: Patch for KAFKA-1544

2014-07-23 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23858/ --- Review request for kafka. Bugs: KAFKA-1544 https://issues.apache.org/jira/b