Re: Review Request 23567: Patch for KAFKA-1522

> On Aug. 14, 2014, 11:15 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/TransactionRequest.scala, line 47 > > > > > > It would help to have comments here describing each type's role. Please check the update

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 15, 2014, 6:37 p.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review50663 --- Ship it! core/src/main/scala/kafka/api/TransactionRequest.scala

Re: Review Request 23567: Patch for KAFKA-1522

> On Aug. 8, 2014, 10:51 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/TransactionRequest.scala, line 41 > > > > > > Although this is "sort-of" a constructor it is a regular method so > > start with lower c

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 9, 2014, 4:21 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review50081 --- core/src/main/scala/kafka/api/TransactionRequest.scala

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 6, 2014, 4:28 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

> On July 21, 2014, 5:49 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/TransactionRequest.scala, line 87 > > > > > > TxControlTypes would be clearer I think (also based on what I have seen > > so far in KAF

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 22, 2014, 11:43 p.m.) Review request for kafka. Bugs: KAFKA-152

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review48259 --- core/src/main/scala/kafka/api/TransactionRequest.scala

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 3:12 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:38 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:37 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:36 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:36 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:36 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:30 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review48098 --- core/src/main/scala/kafka/api/TransactionRequest.scala

Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/b