Re: Review Request 23516: Patch for KAFKA-1462

2014-07-18 Thread Jun Rao
> On July 17, 2014, 9:52 p.m., Guozhang Wang wrote: > > I am not sure why we need to remove correlationId from the > > ReuqestOrResponse in order to do ser/deser. Shouldn't we just add > > correlation_id to the AbstractRequestResponse java class? This is just to make reusing the client request

Re: Review Request 23516: Patch for KAFKA-1462

2014-07-17 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23516/#review48092 --- Ship it! Ship It! - Jay Kreps On July 17, 2014, 4:39 a.m., Jun R

Re: Review Request 23516: Patch for KAFKA-1462

2014-07-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23516/#review48071 --- I am not sure why we need to remove correlationId from the ReuqestOr

Re: Review Request 23516: Patch for KAFKA-1462

2014-07-17 Thread Guozhang Wang
> On July 16, 2014, 11:09 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/Cluster.java, line 18 > > > > > > Do we ever want to use * in imports? > > Jun Rao wrote: > IDE did the optimiz

Re: Review Request 23516: Patch for KAFKA-1462

2014-07-16 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23516/ --- (Updated July 17, 2014, 4:39 a.m.) Review request for kafka. Bugs: KAFKA-1462

Re: Review Request 23516: Patch for KAFKA-1462

2014-07-16 Thread Jun Rao
> On July 16, 2014, 11:09 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/Cluster.java, line 18 > > > > > > Do we ever want to use * in imports? IDE did the optimization since there are too

Re: Review Request 23516: Patch for KAFKA-1462

2014-07-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23516/#review47940 --- clients/src/main/java/org/apache/kafka/common/Cluster.java

Re: Review Request 23516: Patch for KAFKA-1462

2014-07-16 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23516/#review47954 --- clients/src/main/java/org/apache/kafka/common/Cluster.java

Re: Review Request 23516: Patch for KAFKA-1462

2014-07-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23516/ --- (Updated July 15, 2014, 6:36 p.m.) Review request for kafka. Bugs: KAFKA-1462

Review Request 23516: Patch for KAFKA-1462

2014-07-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23516/ --- Review request for kafka. Bugs: KAFKA-1462 https://issues.apache.org/jira/b