Re: Review Request 21937: Patch for KAFKA-1316

> On June 6, 2014, 4:06 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java, > > lines 1-16 > > > > > > Let's use the same license header in the HEADER file. The header com

Re: Review Request 21937: Patch for KAFKA-1316

> On June 6, 2014, 3:18 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java, > > line 69 > > > > > > This API seems unused as well > > Jay Kreps wrote: > Thos

Re: Review Request 21937: Patch for KAFKA-1316

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/ --- (Updated June 7, 2014, 6:20 p.m.) Review request for kafka. Bugs: KAFKA-1316

Re: Review Request 21937: Patch for KAFKA-1316

> On June 6, 2014, 3:18 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 58 > > > > > > Now we will end up with potentially two Senders - one for th

Re: Review Request 21937: Patch for KAFKA-1316

> On June 6, 2014, 5:14 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, line 93 > > > > > > Maybe rename to getReady()? It isn't a getter. It actually is something more

Re: Review Request 21937: Patch for KAFKA-1316

> On June 6, 2014, 3:18 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 58 > > > > > > Now we will end up with potentially two Senders - one for th

Re: Review Request 21937: Patch for KAFKA-1316

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/#review44921 --- clients/src/main/java/org/apache/kafka/clients/InFlightRequests.jav

Re: Review Request 21937: Patch for KAFKA-1316

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/#review44663 --- Thanks for the patch. Could we write short description in the commen

Re: Review Request 21937: Patch for KAFKA-1316

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/#review44850 --- Good to see this patch. Looks great, I have few minor review comment

Re: Review Request 21937: Patch for KAFKA-1316

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/ --- (Updated June 3, 2014, 9:33 p.m.) Review request for kafka. Bugs: KAFKA-1316

Re: Review Request 21937: Patch for KAFKA-1316

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/ --- (Updated June 3, 2014, 6:15 p.m.) Review request for kafka. Summary (updated)