Re: Review Request 21712: Patch for KAFKA-1444

2014-05-22 Thread Neha Narkhede
> On May 22, 2014, 9:14 p.m., Neha Narkhede wrote: > > Thanks. Do we also need to do the same for PartitonMetadata, as the JIRA > > indicates? > > Sriharsha Chintalapani wrote: > Yes its included in the TopicMetadata.scala line 74. > Oh yes, somehow missed it :) - Neha ---

Re: Review Request 21712: Patch for KAFKA-1444

2014-05-22 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21712/#review43779 --- Ship it! Ship It! - Neha Narkhede On May 20, 2014, 5:06 p.m., Sr

Re: Review Request 21712: Patch for KAFKA-1444

2014-05-22 Thread Sriharsha Chintalapani
> On May 22, 2014, 9:14 p.m., Neha Narkhede wrote: > > Thanks. Do we also need to do the same for PartitonMetadata, as the JIRA > > indicates? Yes its included in the TopicMetadata.scala line 74. - Sriharsha --- This is an automatical

Re: Review Request 21712: Patch for KAFKA-1444

2014-05-22 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21712/#review43774 --- Thanks. Do we also need to do the same for PartitonMetadata, as the

Review Request 21712: Patch for KAFKA-1444

2014-05-20 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21712/ --- Review request for kafka. Bugs: KAFKA-1444 https://issues.apache.org/jira/b