Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/ --- (Updated May 15, 2014, 10:19 p.m.) Review request for kafka. Bugs: KAFKA-1445

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-16 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/#review43122 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-16 Thread Guozhang Wang
> On May 15, 2014, 8:47 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 210 > > > > > > Is Node.UNKNOWN better than null? > > > >

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/ --- (Updated May 15, 2014, 10:15 p.m.) Review request for kafka. Bugs: KAFKA-1445

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-16 Thread Jay Kreps
> On May 15, 2014, 8:47 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 201 > > > > > > Instead of a List use a HashSet to avoid the O(N)

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-16 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/#review43157 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-16 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/#review43172 --- Ship it! Ship It! - Jay Kreps On May 15, 2014, 10:19 p.m., Guozh

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/ --- (Updated May 14, 2014, 11:28 p.m.) Review request for kafka. Bugs: KAFKA-1445

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/ --- (Updated May 14, 2014, 11:24 p.m.) Review request for kafka. Bugs: KAFKA-1445

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-15 Thread Guozhang Wang
> On May 14, 2014, 4:31 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > lines 204-247 > > > > > > Could the two loops be merged into a single loop

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-14 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/#review42985 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/#review42982 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-14 Thread Guozhang Wang
> On May 13, 2014, 6:37 p.m., Timothy Chen wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 323 > > > > > > Should we only call forceUpdate once if we get multiple unk

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/#review42921 --- Looks good to me. Some minor comments. clients/src/main/java/org/a

Review Request 21398: Fix KAFKA-1445 v2

2014-05-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/ --- Review request for kafka. Bugs: KAFKA-1445 https://issues.apache.org/jira/b

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/#review42869 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/ --- (Updated May 13, 2014, 6:19 p.m.) Review request for kafka. Bugs: KAFKA-1445

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/ --- (Updated May 13, 2014, 6:25 p.m.) Review request for kafka. Bugs: KAFKA-1445