Review Request 21304: Fix KAFKA-1445

2014-05-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21304/ --- Review request for kafka. Bugs: KAFKA-1445 https://issues.apache.org/jira/b

Re: Review Request 21304: Fix KAFKA-1445

2014-05-12 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21304/#review42734 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 21304: Fix KAFKA-1445

2014-05-12 Thread Guozhang Wang
> On May 12, 2014, 7:35 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 54 > > > > > > Does this need to be volatile? Do we actually need it

Re: Review Request 21304: Fix KAFKA-1445

2014-05-12 Thread Guozhang Wang
> On May 12, 2014, 7:35 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 201 > > > > > > It seems like this only works some of the time. Let