Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round three

> On April 24, 2014, 12:44 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 275-276 > > > > > > We probably should use validMessages here. > > Guozhang Wang wrote: > I actually thought about

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round three

> On April 25, 2014, 12:24 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/log/Log.scala, line 275 > > > > > > Can we compute messages.sizeInBytes just once instead of twice? messages.sizeInBytes just calls b

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round three

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/#review41421 --- core/src/main/scala/kafka/log/Log.scala

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round three

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/ --- (Updated April 24, 2014, 11:26 p.m.) Review request for kafka. Summary (updat