Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

2014-04-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 25, 2014, 9:09 p.m.) Review request for kafka. Bugs: KAFKA-139

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

2014-04-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41521 --- Looks good. Just the following minor comment. core/src/test/scala/

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

2014-04-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 25, 2014, 6:03 p.m.) Review request for kafka. Bugs: KAFKA-139

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

2014-04-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41472 --- Great cleanup patch! Some minor comments. 1. TestUtils.createProdu

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

2014-04-24 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 24, 2014, 11:22 p.m.) Review request for kafka. Summary (updat