Re: Review Request 20190: Patch for KAFKA-1356

2014-04-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20190/#review39992 --- Ship it! core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 20190: Patch for KAFKA-1356

2014-04-10 Thread Timothy Chen
> On April 10, 2014, 2:57 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, lines 62-63 > > > > > > Could we make this class private? Unit tests seems to rely on accessing the cache to verify s

Re: Review Request 20190: Patch for KAFKA-1356

2014-04-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20190/#review40012 --- Thanks for the patch. Some comments below. core/src/main/scala/kaf

Review Request 20190: Patch for KAFKA-1356

2014-04-09 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20190/ --- Review request for kafka. Bugs: KAFKA-1356 https://issues.apache.org/jira/b