Re: Review Request 20030: Patch for KAFKA-1352

2014-04-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20030/#review39714 --- Ship it! Ship It! - Guozhang Wang On April 4, 2014, 6:20 p.m., I

Re: Review Request 20030: Patch for KAFKA-1352

2014-04-04 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20030/ --- (Updated April 4, 2014, 6:20 p.m.) Review request for kafka. Bugs: KAFKA-1352

Re: Review Request 20030: Patch for KAFKA-1352

2014-04-04 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20030/#review39555 --- Thanks for the patch. Some comments below. core/src/main/scala/kaf

Review Request 20030: Patch for KAFKA-1352

2014-04-04 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20030/ --- Review request for kafka. Bugs: KAFKA-1352 https://issues.apache.org/jira/b