Re: Review Request 19490: Patch for KAFKA-1315

2014-03-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/ --- (Updated March 20, 2014, 9:03 p.m.) Review request for kafka. Bugs: KAFKA-131

Re: Review Request 19490: Patch for KAFKA-1315

2014-03-20 Thread Timothy Chen
> On March 20, 2014, 8:41 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, line 93 > > > > > > Don't you still need to change this place? Don't need to change this as getAbsolutePath ma

Re: Review Request 19490: Patch for KAFKA-1315

2014-03-20 Thread Guozhang Wang
> On March 20, 2014, 8:41 p.m., Guozhang Wang wrote: > > Actually, I think all we need is FileSystem.getFileSystem().normalize(pathname). - Guozhang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.

Re: Review Request 19490: Patch for KAFKA-1315

2014-03-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/#review37967 --- core/src/main/scala/kafka/cluster/Partition.scala

Re: Review Request 19490: Patch for KAFKA-1315

2014-03-20 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/#review37964 --- Almost ready for checkin. 2 minor comments after which we can check

Re: Review Request 19490: Patch for KAFKA-1315

2014-03-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/ --- (Updated March 20, 2014, 8:28 p.m.) Review request for kafka. Bugs: KAFKA-131

Re: Review Request 19490: Patch for KAFKA-1315

2014-03-20 Thread Timothy Chen
> On March 20, 2014, 8:20 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, line 93 > > > > > > This creates new File objects on every single getOrCreateReplica. > > During leader change

Re: Review Request 19490: Patch for KAFKA-1315

2014-03-20 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/#review37961 --- Thanks for the quick patch, Tim! core/src/main/scala/kafka/cluster

Review Request 19490: Patch for KAFKA-1315

2014-03-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/ --- Review request for kafka. Bugs: KAFKA-1315 https://issues.apache.org/jira/b