Re: Review Request 19379: Patch for KAFKA-1311

2014-03-18 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/#review37668 --- Ship it! Ship It! - Timothy Chen On March 19, 2014, 12:14 a.m.,

Re: Review Request 19379: Patch for KAFKA-1311

2014-03-18 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/#review37667 --- Ship it! Ship It! - Joel Koshy On March 19, 2014, 12:14 a.m., Ne

Re: Review Request 19379: Patch for KAFKA-1311

2014-03-18 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/#review37666 --- Ship it! Ship It! - Guozhang Wang On March 19, 2014, 12:14 a.m.,

Re: Review Request 19379: Patch for KAFKA-1311

2014-03-18 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/ --- (Updated March 19, 2014, 12:14 a.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 19379: Patch for KAFKA-1311

2014-03-18 Thread Neha Narkhede
> On March 18, 2014, 10:44 p.m., Joel Koshy wrote: > > The delete topic thread will never wake up if delete topic is disabled. > > Nevertheless, could we also check if delete topic is enabled before trying > > to start the deletetopicmanager (and the associated delete topic thread)? hmm.. actu

Re: Review Request 19379: Patch for KAFKA-1311

2014-03-18 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/#review37654 --- The delete topic thread will never wake up if delete topic is disabl

Re: Review Request 19379: Patch for KAFKA-1311

2014-03-18 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/ --- (Updated March 18, 2014, 10:32 p.m.) Review request for kafka. Bugs: KAFKA-13

Review Request 19379: Patch for KAFKA-1311

2014-03-18 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/ --- Review request for kafka. Bugs: KAFKA-1311 https://issues.apache.org/jira/b