Re: Review Request 18740: Fix KAFKA-1286

2014-03-05 Thread Jun Rao
> On March 5, 2014, 12:24 a.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, > > lines 323-324 > > > > > > Actually, why don't we need to close producer during shutdo

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 5, 2014, 1:58 a.m.) Review request for kafka. Bugs: KAFKA-1286

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 5, 2014, 1:57 a.m.) Review request for kafka. Bugs: KAFKA-1286

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
> On March 5, 2014, 12:02 a.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, line 42 > > > > > > I think this may be incorrect if the apikey enums are ever out of order > >

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
> On March 5, 2014, 12:24 a.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, > > lines 307-308 > > > > > > Could we compare the content of unique message set? This w

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/#review36194 --- There are compilation errors when running unit tests. clients/src/

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/#review36195 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
> On March 4, 2014, 9:23 p.m., Jay Kreps wrote: > > core/src/main/scala/kafka/log/LogManager.scala, line 182 > > > > > > Let's not add to log spam... I saw for sub-modules we have some inconsistency: for some of them

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 11:15 p.m.) Review request for kafka. Bugs: KAFKA-128

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 11:15 p.m.) Review request for kafka. Bugs: KAFKA-128

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/#review36152 --- This is very good. I flagged a number of minor things, but basically

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 7:05 p.m.) Review request for kafka. Bugs: KAFKA-1286

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 7:04 p.m.) Review request for kafka. Bugs: KAFKA-1286

Re: Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 6:56 p.m.) Review request for kafka. Bugs: KAFKA-1286

Review Request 18740: Fix KAFKA-1286

2014-03-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- Review request for kafka. Bugs: KAFKA-1286 https://issues.apache.org/jira/b