Re: Review Request 18343: Patch for KAFKA-1250

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35617 --- Ship it! Ship It! - Neha Narkhede On Feb. 27, 2014, 2:32 a.m., J

Re: Review Request 18343: Patch for KAFKA-1250

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/ --- (Updated Feb. 27, 2014, 2:32 a.m.) Review request for kafka. Bugs: KAFKA-1250

Re: Review Request 18343: Patch for KAFKA-1250

> On Feb. 26, 2014, 10:49 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 386 > > > > > > In order to meaningfully trace a request in the producer

Re: Review Request 18343: Patch for KAFKA-1250

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35532 --- 1. Is there a reason that you want to change the license header? We

Re: Review Request 18343: Patch for KAFKA-1250

> On Feb. 25, 2014, 7:14 p.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 227 > > > > > > My understanding is that any per message log message be at t

Re: Review Request 18343: Patch for KAFKA-1250

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35520 --- Thanks for the updated patch, Jay! clients/src/main/java/org/apach

Re: Review Request 18343: Patch for KAFKA-1250

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/ --- (Updated Feb. 26, 2014, 5:32 a.m.) Review request for kafka. Summary (updated