Re: Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.

2014-02-25 Thread Jay Kreps
> On Feb. 25, 2014, 7:14 p.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 122 > > > > > > could we also have config.logOveridden() ? We have two thin

Re: Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.

2014-02-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35507 --- A bunch of other places where I used println but would love to get l

Re: Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.

2014-02-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35431 --- A few remaining things that we need to take care of - 1. Adding pro

Re: Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.

2014-02-21 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35163 --- 1. There is a total of 16 printStackTrace() in the code and only 9 o

Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.

2014-02-20 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/ --- Review request for kafka. Bugs: KAFKA-1250 https://issues.apache.org/jira/b