Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review35593 --- Ship it! Ship It! - Jay Kreps On Feb. 26, 2014, 9:51 p.m., Guozh

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 9:51 p.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

> On Feb. 26, 2014, 7:56 p.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, lines > > 161-162 > > > > > > Shouldn't we add the code to call send after producer.close()? The sec

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 9:49 p.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review35559 --- Ship it! +1 Just the following minor comments. core/src/main/scal

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 5:48 p.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 5:47 p.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

> On Feb. 26, 2014, 2:47 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > lines 230-231 > > > > > > Not sure we need to wrap InterruptedException. We need, sinc

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review35508 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 1:46 a.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 1:46 a.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 12:59 a.m.) Review request for kafka. Bugs: KAFKA-126

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 12:58 a.m.) Review request for kafka. Summary (update

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 19, 2014, 9:51 p.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 19, 2014, 9:49 p.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 14, 2014, 11:02 p.m.) Review request for kafka. Bugs: KAFKA-126

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 14, 2014, 11 p.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

> On Feb. 14, 2014, 7:22 p.m., Jay Kreps wrote: > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, > > line 67 > > > > > > You should be able to create this now. There is a TestUtil in the

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review34437 --- Is there a case for failure and recovery. The scenario I am most int

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 13, 2014, 11:16 p.m.) Review request for kafka. Bugs: KAFKA-126

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 13, 2014, 11:14 p.m.) Review request for kafka. Bugs: KAFKA-126

Re: Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 13, 2014, 11:13 p.m.) Review request for kafka. Bugs: KAFKA-126

Review Request 18102: Integration Test for New Producer: Part II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- Review request for kafka. Bugs: KAFKA-1260 https://issues.apache.org/jira/b