Re: Review Request 17921: Misc fixes for perf tools.

2014-02-10 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17921/#review34155 --- Ship it! - Neha Narkhede On Feb. 10, 2014, 9:49 p.m., Jay Kreps w

Re: Review Request 17921: Misc fixes for perf tools.

2014-02-10 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17921/#review34154 --- Ship it! - Neha Narkhede On Feb. 10, 2014, 9:49 p.m., Jay Kreps w

Re: Review Request 17921: Misc fixes for perf tools.

2014-02-10 Thread Jay Kreps
> On Feb. 11, 2014, 12:49 a.m., Neha Narkhede wrote: > > 1. The JIRA attached to this rb is incorrect. Yeah I made another, but since you commented on this one, I'll review here. > On Feb. 11, 2014, 12:49 a.m., Neha Narkhede wrote: > > perf/src/main/scala/kafka/perf/ProducerPerformance.scala,

Re: Review Request 17921: Misc fixes for perf tools.

2014-02-10 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17921/#review34135 --- 1. The JIRA attached to this rb is incorrect. bin/kafka-run-class.

Re: Review Request 17921: Misc fixes for perf tools.

2014-02-10 Thread Jay Kreps
Ignore this, I attached the review to the wrong ticket. Created a new review request to fix it. On Mon, Feb 10, 2014 at 1:49 PM, Jay Kreps wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apach

Review Request 17921: Misc fixes for perf tools.

2014-02-10 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17921/ --- Review request for kafka. Bugs: KAFKA-1255 https://issues.apache.org/jira/b