Re: Review Request 16814: Patch for KAFKA-1202

2014-01-14 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16814/#review31815 --- Ship it! Ship It! - Neha Narkhede On Jan. 14, 2014, 7:56 p.m., J

Re: Review Request 16814: Patch for KAFKA-1202

2014-01-14 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16814/#review31803 --- Ship it! Ship It! - Guozhang Wang On Jan. 14, 2014, 7:56 p.m., J

Re: Review Request 16814: Patch for KAFKA-1202

2014-01-14 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16814/ --- (Updated Jan. 14, 2014, 7:56 p.m.) Review request for kafka. Bugs: KAFKA-1202

Re: Review Request 16814: Patch for KAFKA-1202

2014-01-14 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16814/ --- (Updated Jan. 14, 2014, 7:55 p.m.) Review request for kafka. Summary (updated

Re: Review Request 16814: Patch for KAFKA-1202

2014-01-14 Thread Jun Rao
> On Jan. 14, 2014, 2:41 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala, line 173 > > > > > > We discussed this offline, but may be good to document the motivation > > f

Re: Review Request 16814: Patch for KAFKA-1202

2014-01-14 Thread Jun Rao
> On Jan. 13, 2014, 6:43 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala, line 102 > > > > > > Like the comment above says "The reassigned replicas are ALL in the in >

Re: Review Request 16814: Patch for KAFKA-1202

2014-01-13 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16814/#review31693 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 16814: Patch for KAFKA-1202

2014-01-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16814/#review31626 --- core/src/main/scala/kafka/controller/KafkaController.scala

Review Request 16814: Patch for KAFKA-1202

2014-01-12 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16814/ --- Review request for kafka. Bugs: KAFKA-1202 https://issues.apache.org/jira/b